Skip to content

feat: add 14 additional chart types#20

Merged
Nebu1eto merged 3 commits into
mainfrom
dev/phase-c-chart-types
Feb 10, 2026
Merged

feat: add 14 additional chart types#20
Nebu1eto merged 3 commits into
mainfrom
dev/phase-c-chart-types

Conversation

@Nebu1eto

Copy link
Copy Markdown
Owner

Summary

  • Add 14 new chart types bringing the total from 43 to 57: OfPie (PieOfPie, BarOfPie), 3D shape columns (Cone, Pyramid, Cylinder with clustered/stacked/percentStacked variants), Contour (Contour, WireframeContour), and Bubble3D
  • XML schema additions: OfPieChart/SerLines structs, shape field on Bar3DChart, bubble_3d on BubbleSeries, of_pie_chart on PlotArea
  • Node.js bindings updated with 14 new string mappings in parse_chart_type()
  • English and Korean documentation updated with all new chart types

Test plan

  • Rust tests: 1253 core tests + 181 XML tests pass (including 17 new chart-specific tests)
  • Node.js tests: 269 tests pass (including 15 new chart type tests)
  • cargo clippy --workspace passes with no warnings
  • cargo fmt --check passes
  • pnpm biome check . passes

Generated with Claude Code

@Nebu1eto Nebu1eto closed this Feb 10, 2026
@Nebu1eto Nebu1eto reopened this Feb 10, 2026

@Nebu1eto Nebu1eto left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the added chart types and XML wiring. I did not find a blocking correctness issue in this pass.

@Nebu1eto Nebu1eto left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed review notes:

Good expansion of chart-type coverage and XML schema support. The enum and writer wiring are consistent with existing chart architecture.

What looks good:

  • Added types are integrated across core chart builder, XML structs, docs, and TS tests.
  • Tests cover major serialization points for new chart families.

Follow-up suggestions:

  • Add at least one integration test per new family that reopens the saved workbook and validates the expected chart node exists in chart XML.
  • Consider adding negative/validation tests for invalid combinations (for example missing series fields required by bubble variants).
  • For of-pie variants, document and test defaults for split behavior/options so consumers know what Excel behavior to expect.

Nebu1eto and others added 3 commits February 10, 2026 17:09
… contour, bubble3D)

Add support for 14 new chart types bringing the total from 43 to 57:
- OfPie: PieOfPie, BarOfPie (new ofPieChart XML element)
- Cone columns: Col3DCone, Col3DConeStacked, Col3DConePercentStacked
- Pyramid columns: Col3DPyramid, Col3DPyramidStacked, Col3DPyramidPercentStacked
- Cylinder columns: Col3DCylinder, Col3DCylinderStacked, Col3DCylinderPercentStacked
- Contour: Contour, WireframeContour (surface chart 2D projection)
- Bubble3D (bubble chart with 3D effect per series)

XML schema changes: OfPieChart/SerLines structs, shape field on Bar3DChart,
bubble_3d field on BubbleSeries, of_pie_chart field on PlotArea.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Nebu1eto
Nebu1eto force-pushed the dev/phase-c-chart-types branch from bd3112d to 0351158 Compare February 10, 2026 08:10
@Nebu1eto
Nebu1eto merged commit 04a9264 into main Feb 10, 2026
3 checks passed
@Nebu1eto
Nebu1eto deleted the dev/phase-c-chart-types branch February 10, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant