feat: add 14 additional chart types#20
Merged
Merged
Conversation
Nebu1eto
commented
Feb 10, 2026
Nebu1eto
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the added chart types and XML wiring. I did not find a blocking correctness issue in this pass.
Nebu1eto
commented
Feb 10, 2026
Nebu1eto
left a comment
Owner
Author
There was a problem hiding this comment.
Detailed review notes:
Good expansion of chart-type coverage and XML schema support. The enum and writer wiring are consistent with existing chart architecture.
What looks good:
- Added types are integrated across core chart builder, XML structs, docs, and TS tests.
- Tests cover major serialization points for new chart families.
Follow-up suggestions:
- Add at least one integration test per new family that reopens the saved workbook and validates the expected chart node exists in chart XML.
- Consider adding negative/validation tests for invalid combinations (for example missing series fields required by bubble variants).
- For of-pie variants, document and test defaults for split behavior/options so consumers know what Excel behavior to expect.
… contour, bubble3D) Add support for 14 new chart types bringing the total from 43 to 57: - OfPie: PieOfPie, BarOfPie (new ofPieChart XML element) - Cone columns: Col3DCone, Col3DConeStacked, Col3DConePercentStacked - Pyramid columns: Col3DPyramid, Col3DPyramidStacked, Col3DPyramidPercentStacked - Cylinder columns: Col3DCylinder, Col3DCylinderStacked, Col3DCylinderPercentStacked - Contour: Contour, WireframeContour (surface chart 2D projection) - Bubble3D (bubble chart with 3D effect per series) XML schema changes: OfPieChart/SerLines structs, shape field on Bar3DChart, bubble_3d field on BubbleSeries, of_pie_chart field on PlotArea. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nebu1eto
force-pushed
the
dev/phase-c-chart-types
branch
from
February 10, 2026 08:10
bd3112d to
0351158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OfPieChart/SerLinesstructs,shapefield onBar3DChart,bubble_3donBubbleSeries,of_pie_chartonPlotAreaparse_chart_type()Test plan
cargo clippy --workspacepasses with no warningscargo fmt --checkpassespnpm biome check .passesGenerated with Claude Code