feat: add 54 financial and engineering formula functions#22
Merged
Conversation
Nebu1eto
commented
Feb 10, 2026
Nebu1eto
left a comment
Owner
Author
There was a problem hiding this comment.
Completed a formula-function pass focused on integration points and tests. No blocking issue found in this review round.
Nebu1eto
commented
Feb 10, 2026
Nebu1eto
left a comment
Owner
Author
There was a problem hiding this comment.
Detailed review notes:
The function expansion is substantial and test coverage is broad. The implementation style aligns with existing formula engine patterns.
What looks good:
- Clear function grouping and consistent evaluator integration.
- Strong volume of examples and expectation tests across new functions.
Suggested hardening:
- Add explicit edge tests for extreme numeric values (very large/small magnitudes) where floating-point instability can surface.
- Add dedicated behavior tests for error propagation order (for example invalid arg type vs range error precedence).
- Consider adding compatibility snapshots for a small set of formulas against Excel outputs to reduce semantic drift risk over time.
Add 21 financial functions (FV, PV, NPV, IRR, PMT, IPMT, PPMT, RATE, NPER, DB, DDB, SLN, SYD, EFFECT, NOMINAL, DOLLARDE, DOLLARFR, CUMIPMT, CUMPRINC, XNPV, XIRR) and 33 engineering functions (base conversion, complex number arithmetic, ERF/ERFC, CONVERT, Bessel functions, DELTA, GESTEP) with 80 new tests. Total supported formula functions: 164. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nebu1eto
force-pushed
the
dev/phase-b-formula-fin-eng
branch
from
February 10, 2026 08:11
f14232f to
5488fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo build --workspacepassescargo test --workspacepasses (1508 tests total, 80 new)cargo clippy --workspacepasses (no warnings)cargo fmt --checkpassespnpm build && pnpm vitest runpasses (254 Node.js tests)🤖 Generated with Claude Code