feat: add form controls (C2)#38
Merged
Merged
Conversation
Add 7 form control types (Button, CheckBox, OptionButton, SpinButton, ScrollBar, GroupBox, Label) using legacy VML drawing infrastructure. Controls support cell linking, macro binding, value ranges, and 3D shading. VML content is automatically merged when both comments and form controls exist on the same sheet. Includes Rust core module (44 tests), napi bindings (11 tests), TypeScript wrapper, and English/Korean documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When opening a workbook from file, existing form controls were stored only as raw VML bytes in sheet_vml, while sheet_form_controls remained empty. This caused add_form_control to silently drop pre-existing controls (by overwriting VML with only the new control) and delete_form_control to always fail with out-of-bounds errors. Add a hydrate_form_controls helper that lazily parses VML data into sheet_form_controls before add/delete/get operations. This ensures all three methods correctly see pre-existing controls from opened files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-raised from #35 after rebase onto main. Adds form controls support (buttons, checkboxes, drop-downs) via VML drawing parts.