fix: resolve race condition in cli_tests create_fixture()#54
Merged
Conversation
Multiple test threads calling create_fixture() concurrently could read a partially-written xlsx file. One thread starts writing the fixture while another sees path.exists() == true and returns the incomplete file, causing "invalid Zip archive: Could not find EOCD" errors. Wrap the initialization in std::sync::OnceLock so only one thread creates the file and all others block until it is fully written. https://claude.ai/code/session_01Bjb6FrfgvHaS4RUtMsmNQk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple test threads calling create_fixture() concurrently could read a
partially-written xlsx file. One thread starts writing the fixture while
another sees path.exists() == true and returns the incomplete file,
causing "invalid Zip archive: Could not find EOCD" errors.
Wrap the initialization in std::sync::OnceLock so only one thread
creates the file and all others block until it is fully written.
https://claude.ai/code/session_01Bjb6FrfgvHaS4RUtMsmNQk