Add ARB Alert Rules toggle to ARB Status tab (v0.5.8)#1
Closed
mgodfre3 wants to merge 1 commit into
Closed
Conversation
Owner
|
@mgodfre3 - If you can resync your fork with main, and address the merge conflict, I will review this, sorry I missed it earlier and pushed several more releases. |
Contributor
Author
|
Fixed the merge issue, should be good to go now. |
mgodfre3
force-pushed
the
feature/arb-alert-rules-toggle
branch
from
January 23, 2026 17:08
6d9f80d to
2726fa5
Compare
mgodfre3
referenced
this pull request
in mgodfre3/Azure-Local
Jan 28, 2026
…c42-4ee4-b232-da54156ee9e1 Adding Microsoft SECURITY.MD
NeilBird
added a commit
that referenced
this pull request
May 12, 2026
1. TryParse for IP validation (PR comment #2): - Convert all 4 [IPAddress]::Parse sites in Get-AzLocalNetworkSettingsFromJson to [IPAddress]::TryParse([ref]) - avoids exception-handling overhead and yields a stable, actionable error message (no longer depends on localised .NET exception text). Applied consistently across subnetMask, defaultGateway, startingIPAddress, endingIPAddress, nodeIPAddresses, and the new dnsServers block. 2. Soften source-text precedence guard (PR comment #1): - Replace exact-identifier regex with loose intent-based patterns so the test survives variable renames or whitespace changes. The behaviour-level coverage already lives in the dedicated parser Describe block; this guard remains as a cheap regression catch for someone deleting the resolution block entirely. - Did NOT extract a Resolve-AzLocalDnsServers helper as suggested - 8 lines of straight-line code in one call site doesn't warrant a new abstraction (per repo implementationDiscipline guidance). Pester: 532/532 passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added new Alert Rules Configuration section to the ARB Status tab.
Changes
Toggle control: Show/hide alert rules setup panel (defaults to hidden)
ARB Alert Rules Table: Lists all Arc Resource Bridges with direct links to create Resource Health and Activity Log alerts
Prerequisites documentation: Action Groups, permissions, Resource Health support
Recommended alert types: Offline Status, Resource Health states, Extended Offline (>14 days)
Manual alert rule creation steps: Including ARG query for bulk monitoring
Quick links: Action Groups, Alert Rules, and troubleshooting documentation
Benefits
Enables users to easily configure alerts for ARB offline states and other issues, helping prevent the 45-day security key expiration issue.