fix(connections): align form select + input heights - #76
Merged
Conversation
Native <select> rendered a couple px taller than text <input> at the same padding (different default line-box metrics), so paired rows like Database+SSL and Environment+Color looked slightly uneven. Give both an explicit height (30px) + matching line-height so they line up exactly. Regenerate the connection-form screenshot.
The height fix accidentally applied the native-chevron removal + arrow to text inputs too (they shared the rule). Split it: the shared rule handles height/border/padding for input+select; a select-only rule drops the native chevron and draws a custom one at a fixed 10px from the edge. Text inputs render clean (no arrow); selects have uniform arrow spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native
<select>was rendering a couple px taller than the text<input>at the same padding (browsers give them different default line-box metrics), so paired rows — Database+SSL, Environment+Color — looked slightly uneven.Give both an explicit
height: 30px+ matchingline-heightso they align exactly. Regenerated the connection-form screenshot to confirm.Gate: lint (0 errors) + 260 unit tests pass.