Hitbox group pen - #2002
Merged
AdamTadeusz merged 4 commits intoAug 3, 2026
Merged
Conversation
AdamTadeusz
marked this pull request as draft
June 30, 2026 17:42
AdamTadeusz
marked this pull request as ready for review
June 30, 2026 18:57
AdamTadeusz
commented
Jul 1, 2026
AdamTadeusz
added
the
New Changes for Reviewers
sunmachine
previously approved these changes
Jul 31, 2026
sunmachine
left a comment
sunmachine
left a comment
Contributor
There was a problem hiding this comment.
Just nit-picks so far, like taking a second pass at some indentations here and there, cleanup a TODO, blah blah.
The only thing I thought I had a bite on was HITBOX_GEAR as pondering why/how it would be used. Then I realize we don't use those hit boxes at all, do we?
Then I'm toying around on raycast perf, but even the worst case is a big "so what".
Good addition. LGTM.
Contributor
Author
|
We indeed don't use HITBOX_GEAR. I thought that it might be for things like pouches or other jiggle bones or whatever attached to the player model, but now I'm wondering if it's used for things like ballistic shields, and if so, we actually definitely shouldn't be doing this check, so I think ill remove it. |
sunmachine
approved these changes
Aug 1, 2026
sunzenshen
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any bullet that hits a player model extremity now does a second check where it hit a player while ignoring those hitbox groups, generally decreasing the ttk as for example arms no longer block shots to the chest.
Currently stops shots that would have gibbed a model from doing so if the shot ends up hitting a main hitbox behind it, I'm going to say that's fine for now? My explanation for that is uhh the limb has something to brace against so it doesn't pop off as easily.
Might need to ask the community what they think.
Shotguns are very scary now.
Tbh even an srm shreds now.
Toolchain