Fix spi disable #41
Merged
Fix spi disable #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2022
Detegr
reviewed
Jan 2, 2023
Contributor
There was a problem hiding this comment.
I would split this commit up a bit for readability as it contains some reformatting stuff in it and a vscode settings file.
Member
Author
|
Yeah, you're right. I should. |
Member
Author
thejpster
force-pushed
the
fix-spi-disable
branch
from
ea827d5 to
5c9446c
Compare
Member
Author
|
Hopefully that's a bit cleaner - the formatting changes got pushed into the earlier commit. |
Member
Author
|
Ok merge time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves SPI disable/enable into the main thread. Also changes to using the internal NSS signal instead of brutally enabling/disabling the whole SPI module. This fixes the bug where we sometimes had a couple of bits stuck in the FIFO.