feat: add filter to eseries collector - #4387
Merged
Merged
Conversation
cgrinds
approved these changes
Aug 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the ESeries collector to append configured query filters to its REST endpoint URL when polling data, and updates unit tests to validate the URL-building behavior.
Changes:
- Add
Prop.Filtersupport to the ESeries collector’sPollData()URL construction. - Update
TestESeries_URLBuilderto include filters and assert the expected query string output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/collectors/eseries/eseries.go | Append configured filters to the REST query URL during data polling. |
| cmd/collectors/eseries/eseries_test.go | Update URL builder test to cover filter query string generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
243
to
247
| query := rest.NewURLBuilder(). | ||
| APIPath(e.Prop.Query). | ||
| ArrayID(e.arrayID). | ||
| Filter(e.Prop.Filter). | ||
| Build() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.