[libedit] Register signal handler with SA_ONSTACK flag.#40
Closed
tkoeppe wants to merge 1 commit intoNetBSD:trunkfrom
Closed
[libedit] Register signal handler with SA_ONSTACK flag.#40tkoeppe wants to merge 1 commit intoNetBSD:trunkfrom
tkoeppe wants to merge 1 commit intoNetBSD:trunkfrom
Conversation
This allows the handler to use the alternate signal stack if one is available in the handling thread, but has no effect otherwise. This change makes the signal handler respect existing choices better. Specifically, this allows signal handlers to be set when the process includes a Go runtime, since Go enforces that _all_ signal handlers in the process use the SA_ONSTACK flag (e.g. see golang/go#20400).
Contributor
|
Committed, thanks. |
Author
|
Nice, thanks a lot! |
netbsd-srcmastr
pushed a commit
that referenced
this pull request
Oct 1, 2025
sys/arch/arm/include/cpufunc.h: revision 1.92 sys/arch/arm/arm32/bus_dma.c: revision 1.150 arm: Adjust barriers issued in bus_dmamap_sync for the coherent case. PR/59654 This change adjusts the memory barriers issued by bus_dmamap_sync for the coherent case. In the non-coherent case the CPU cache operations are expected to provide any, and all required barriers. These barriers are emitted after bouncing for PREWRITE and before bouncing for POSTREAD. A new indrection is introduced to deal with the differencs in barrier (dsb) options between Arm V8 and V7, the lack of options in Arm V6, and the need to use cpu_drain_writebuf for all other earlier versions. The Arm V8 Net change is: op old new --------------------- ---------------------- ------------ PREREAD none dsb(osh) PREWRITE cpu_drain_writebuf dsb(oshst) PREREAD|PREWRITE cpu_drain_writebuf dsb(osh) POSTREAD cpu_drain_writebuf dsb(oshld) POSTWRITE none none POSTREAD|POSTWRITE cpu_drain_writebuf dsb(oshld) where cpu_drain_writebuf is a dsb(sy) or CPU equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the handler to use the alternate signal stack if one is available in the handling thread, but has no effect otherwise.
This change makes the signal handler respect existing choices better. Specifically, this allows signal handlers to be set when the process includes a Go runtime, since Go enforces that all signal handlers in the process use the SA_ONSTACK flag (e.g. see golang/go#20400).