Skip to content

Yes, even Bypass gets a test. - #509

Merged
apanda merged 1 commit into
masterfrom
add_test_for_bypass_module
Jun 13, 2017
Merged

Yes, even Bypass gets a test.#509
apanda merged 1 commit into
masterfrom
add_test_for_bypass_module

Conversation

@justinemarie

Copy link
Copy Markdown
Contributor

Codecov codecov!

@codecov

codecov Bot commented Jun 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #509 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #509   +/-   ##
======================================
- Coverage      65%     64%   -1%     
======================================
  Files         198     198           
  Lines       12062   12062           
======================================
- Hits         7844    7759   -85     
- Misses       4218    4303   +85
Impacted Files Coverage Δ
core/modules/buffer.h 0% <0%> (-100%) ⬇️
core/modules/port_inc.h 0% <0%> (-100%) ⬇️
core/modules/buffer.cc 4% <0%> (-96%) ⬇️
core/modules/port_inc.cc 5% <0%> (-68%) ⬇️
core/modules/nat.cc 70% <0%> (-11%) ⬇️
core/pktbatch.h 83% <0%> (-8%) ⬇️
core/traffic_class.cc 91% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b9a3a...c1d416e. Read the comment docs.

@justinemarie
justinemarie requested review from apanda and sangjinhan and removed request for sangjinhan June 12, 2017 22:30

@apanda apanda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apanda
apanda merged commit 489bb00 into master Jun 13, 2017
@apanda

apanda commented Jun 13, 2017

Copy link
Copy Markdown
Member

Merged. Thanks!!

image

@sangjinhan
sangjinhan deleted the add_test_for_bypass_module branch June 14, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants