travis: Use grpcio 1.4.0.#628
Closed
ddiproietto wants to merge 2 commits intoNetSys:masterfrom
Closed
Conversation
grpcio 1.6.0 (released yesterday) creates problems to the BESS testsuite. Until we figure out how to make it work, use grpcio 1.4.0. This fixes a travis failure observed on master.
chris3torek
approved these changes
Aug 31, 2017
Collaborator
chris3torek
left a comment
chris3torek
left a comment
There was a problem hiding this comment.
LGTM, can tweak the README.md file quotes thing later if at all.
|
|
||
| sudo apt-get install -y python python-pip python-scapy libgraph-easy-perl | ||
| pip install grpcio | ||
| pip install grpcio<=1.4.0 |
Collaborator
There was a problem hiding this comment.
Trivial: should have quotes around this since these are shell commands people might want to cut-and-paste.
Contributor
Author
There was a problem hiding this comment.
Good point, thanks!
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
======================================
Coverage 69.3% 69.3%
======================================
Files 204 204
Lines 13072 13072
======================================
Hits 9059 9059
Misses 4013 4013
Continue to review full report at Codecov.
|
Contributor
Author
|
We have a workaround for the tests, it's better to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpcio 1.6.0 (released yesterday) creates problems to the BESS testsuite.
Until we figure out how to make it work, use grpcio 1.4.0. This fixes a
travis failure observed on master.