Skip to content

[4.4] uams: warn when Randnum afppasswd key file is missing#2973

Merged
rdmark merged 1 commit into
branch-netatalk-4-4from
rdmark-randnum-security-warning
May 10, 2026
Merged

[4.4] uams: warn when Randnum afppasswd key file is missing#2973
rdmark merged 1 commit into
branch-netatalk-4-4from
rdmark-randnum-security-warning

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented May 9, 2026

Log a security warning when the Randnum UAM falls back to clear-text afppasswd entries because the companion key file is not present or the configured path is too long.

The warning notes that this insecure fallback is deprecated and will become a hard failure in a future release.

Also allow the boundary case where the afppasswd path exactly leaves room for the ".key" suffix plus terminator, avoiding an unnecessary key-path failure.

Additionally: build astyle v3.6.14 from scratch for code formatting job, because they introduced multiple regression bugs in 3.6.15 (reported upstream).

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 9, 2026

🤖 Augment PR Summary

Summary: Adds explicit security warnings when the Randnum UAM cannot use the afppasswd companion key file and therefore falls back to clear-text password entries.
Changes: Logs warnings for a missing .key file and for afppasswd paths too long to derive the key path, noting this fallback is deprecated and will become a hard failure.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread etc/uams/uams_randnum.c Outdated
Comment thread etc/uams/uams_randnum.c
@rdmark rdmark force-pushed the rdmark-randnum-security-warning branch from b225d46 to 3b98fd3 Compare May 9, 2026 14:53
@rdmark rdmark requested a review from andylemin May 9, 2026 14:54
@rdmark rdmark force-pushed the rdmark-randnum-security-warning branch 3 times, most recently from 2fb3960 to b1f1284 Compare May 9, 2026 22:04
@andylemin
Copy link
Copy Markdown
Contributor

@rdmark LGTM. just some formatting to fix

@andylemin
Copy link
Copy Markdown
Contributor

@dependabot rebase

@andylemin
Copy link
Copy Markdown
Contributor

@dependabot recreate

Log a security warning when the Randnum UAM falls back to
clear-text afppasswd entries because the companion key file
is not present or the configured path is too long.

The warning notes that this insecure fallback is deprecated and will
become a hard failure in a future release.

Also allow the boundary case where the afppasswd path exactly leaves
room for the ".key" suffix plus terminator, avoiding an unnecessary
key-path failure.
@rdmark rdmark force-pushed the rdmark-randnum-security-warning branch from b1f1284 to aa852a4 Compare May 10, 2026 04:29
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented May 10, 2026

@andylemin dependabot is only allowed to push to PRs that it created ;)

@sonarqubecloud
Copy link
Copy Markdown

@rdmark rdmark merged commit 6a3f216 into branch-netatalk-4-4 May 10, 2026
32 of 33 checks passed
@rdmark rdmark deleted the rdmark-randnum-security-warning branch May 10, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants