pass array of unique movies to serializer

[sdsd08013]

According to JSON API document, id should be unique.
https://jsonapi.org/format/#document-resource-objects

id of movie generated by let(:movie) is always same.
https://github.com/Netflix/fast_jsonapi/blob/master/spec/shared/contexts/movie_context.rb#L438

So I replace array passed to serializer [movies, movies] to build_movies(2)

before:

MovieSerializer.new([movie, movie], options)

after:

movies = build_movies(2)
MovieSerializer.new(movies, options)

[dillonwelch]

The problem I see with this change in the documentation is that the variable movies is never declared (as far as I could tell) within the documentation. More of a nitpick than a usage issue.

[sdsd08013]

right.
I'm thinking about adding the below to Sample Object document

movies = 2.times.map do |i|
           m = Movie.new
           m.id = i + 1
           m.name = 'test movie'
           m.actor_ids = [1, 2, 3]
           m.owner_id = 3
           m.movie_type_id = 1
           m
         end

and replace [movie, movie] statement in the documentation to declared movies .

How do you think about the above change?

[dillonwelch]

I wouldn't think you would want the title of both movies to be test movie. Other than that, seems appropriate.

[dillonwelch]

What do you think about making this a let so you only have to declare it once?

[sdsd08013]

thanks. I'll replace redundant code by using let statement.