fix: few repo adjustments - #1868
Open
Tbaile wants to merge 4 commits into
Open
Conversation
Tbaile
commented
Aug 6, 2026
Tbaile
commented
Collaborator
- fix(ns-plug): trimming initial v from the openwrt version: closes Installing upstream OpenWrt packages fails due to malformed version string #1838
- fix: not using custom feeds when automatic updating: closes Automatic package updates bypass custom feeds exclusion #1867
- build: compiling nano and htop: requested by community: https://community.nethserver.org/t/upstream-openwrt-packages-installation-not-working/28220/5
During nightly updates or click on the UI if the custom feeds is in, APK will use the repos and possible update by error packages from upstream. This will remove the custom feeds during updates by machine but not through the bare command `apk`.
gsanchietti
reviewed
Aug 6, 2026
| @@ -0,0 +1,2 @@ | |||
| CONFIG_PACKAGE_nano-full=m | |||
|
No newline at end of file |
|||
| DISABLED="${CUSTOMFEEDS}.disabled" | ||
|
|
||
| exec 9>"$LOCK" | ||
| flock 9 |
Member
There was a problem hiding this comment.
Why flock is needed?
apk should already handle the lock
Member
There was a problem hiding this comment.
Confirmed: apk handles the lock.
When another instance is running, this is the error that apk returns:
ERROR: Unable to lock database: Resource temporarily unavailable
ERROR: Failed to open apk database: Resource temporarily unavailable
Collaborator
Author
There was a problem hiding this comment.
I'm not concerned about apk, more about the file move. We could lose the custom feeds if concurrent requests are being made, if it's acceptable, I'll remove it no problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.