Renamed batch to proposal for shasta#901
Renamed batch to proposal for shasta#901mskrzypkows merged 2 commits intoproposal_bulding_in_separate_threadfrom
Conversation
…ermindEth/Catalyst into proposal_builder
There was a problem hiding this comment.
Pull request overview
This PR aligns Shasta node terminology and APIs from “batch” to “proposal”, reflecting the proposal-centric workflow used throughout the node and L1/L2 interactions.
Changes:
- Renames the internal builder from
BatchBuildertoProposalBuilderand updates related method/variable names. - Updates logs and messages from “batch” to “proposal” across node components.
- Renames the L1 submission API from
send_batch_to_l1tosend_proposal_to_l1and updates call sites.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shasta/src/node/verifier.rs | Updates log/comment wording from batch to proposal. |
| shasta/src/node/proposal_manager/proposal_builder.rs | Renames builder type + methods and updates proposal submission path. |
| shasta/src/node/proposal_manager/mod.rs | Switches manager wiring from batch builder to proposal builder and updates related calls/logs. |
| shasta/src/node/mod.rs | Renames batch_builder_config parameter to proposal_builder_config and updates logs. |
| shasta/src/node/last_safe_l2_block_finder/mod.rs | Uses proposal-id terminology for last-safe lookup + logging. |
| shasta/src/lib.rs | Renames local config variable passed into the node to proposal builder config. |
| shasta/src/l2/taiko.rs | Renames Taiko wrapper APIs to proposal terminology; adjusts call sites. |
| shasta/src/l1/execution_layer.rs | Renames the L1 submission method to send_proposal_to_l1 and updates error strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pub async fn get_pending_l2_tx_list_from_l2_engine( | ||
| &self, | ||
| base_fee: u64, | ||
| batches_ready_to_send: u64, | ||
| proposals_ready_to_send: u64, | ||
| gas_limit: u64, |
There was a problem hiding this comment.
get_pending_l2_tx_list_from_l2_engine renames the parameter to proposals_ready_to_send, but the underlying common::l2::engine::L2Engine::get_pending_l2_tx_list still models this value as batches_ready_to_send and uses it for tx-list throttling. To avoid semantic drift/confusion, either keep the naming consistent with the underlying API (batch terminology), or add an explicit comment here documenting that “proposal” and “batch” counts are the same quantity in this context.
| pub async fn get_last_block_id_by_proposal_id(&self, proposal_id: u64) -> Result<u64, Error> { | ||
| match self | ||
| .l2_engine | ||
| .get_last_block_id_by_batch_id(batch_id) | ||
| .get_last_block_id_by_batch_id(proposal_id) | ||
| .await? |
There was a problem hiding this comment.
get_last_block_id_by_proposal_id currently delegates to l2_engine.get_last_block_id_by_batch_id(...), which calls the taikoAuth_lastBlockIDByBatchID RPC method. If “proposal id” is just a terminology rename of “batch id”, please document that here; otherwise, this should call a proposal-id-specific engine/RPC method to avoid returning incorrect results when the IDs diverge.
mskrzypkows
merged commit 56e52ae
into
proposal_bulding_in_separate_thread
* Extended poposal transaction monitor with transaction building. Building the blob sidecar (EIP-7584) takes more than 0.5 seconds. Moving it to a separate thread keeps the main pre-confirmation heartbeat running at consistent intervals. Proposal builder passed as parameter for transaction monitor. * Updated dep * review, fixed wrong handling of error from submitted trasactions * Corrected handling not submitted proposal which need to be submitted again * comment * Update shasta/src/node/proposal_manager/batch_builder.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update shasta/src/l1/proposal_tx_builder.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Build failed error instead of estimation error * Renamed batch to proposal for shasta (#901) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.