feat(shasta): fall back to anchorV3 decoding when anchorV4 decode fails#925
Merged
mikhailUshakoff merged 3 commits intomasterfrom Mar 30, 2026
Merged
feat(shasta): fall back to anchorV3 decoding when anchorV4 decode fails#925mikhailUshakoff merged 3 commits intomasterfrom
mikhailUshakoff merged 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds backward-compatible decoding of Shasta anchor transaction calldata by falling back to anchorV3 decoding when anchorV4 decoding fails, supporting mixed/older anchor formats.
Changes:
- Introduce an
alloy::sol!ABI binding foranchorV3and use it as a fallback when decoding anchor IDs from tx input data. - Update
decode_anchor_id_from_tx_datato tryanchorV4first, thenanchorV3. - Bump workspace crate version to
1.35.0(and refreshCargo.lock).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| shasta/src/l2/execution_layer.rs | Adds an anchorV3 ABI definition and fallback decoding logic for extracting the anchor block id from calldata. |
| Cargo.toml | Bumps workspace package version to 1.35.0. |
| Cargo.lock | Updates workspace crate versions to 1.35.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mskrzypkows
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.