Fix peers not set propertly on statefulset for execution-beacon#72
Merged
Fix peers not set propertly on statefulset for execution-beacon#72
Conversation
aivarasko
approved these changes
Dec 11, 2023
0xDones
approved these changes
Dec 11, 2023
matilote
added a commit
that referenced
this pull request
Dec 18, 2023
* feat: add lodestar (#56) * feat: add lodestar validator * refactor: remove hpa * fix: remove autoscaling * refactor: change bash to sh * feat: add http port and fix probes * feat: add rest for checks * chore: remove probes * Add envFrom to execution container (#67) * Add envFrom to execution container in case we have externalSecrets enabled * Set seq as part of the charts and not as a extraflag * clean up seq and mining extraData on nethermind execution charts * Remove space on charts * Fix peers not set propertly on statefulset for execution-beacon (#72) * Fix peers not set propertly on statefulset for execution-beacon * Switch to targetPeers * remove teku prune option * define upperbound peers for neku * add min targetPeers for teku lower bound --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Denis Policastro <denis.policastro@gmail.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
AntiD2ta
added a commit
that referenced
this pull request
Jan 23, 2024
* Update cm name * Extract to script * Add watcher scripts * Update watcher.sh * fixes * Add --no-of-keys as param * Add --no-of-keys as param * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * Add sigterm handler * Use bash wrapper * Simplify code * Init chart dirk * Remove main container for now * Remove not needed secrets * Remove old type secrets * Fix sleeping * Fix bash path * Change looper * Change looper * Change ranger * fix * fix * New range * New range * Fixes * Fixes * More replicas * More replicas * More replicas * Add 2 * Add 2 * fix * fix * fix * fix * Add missing separator * Add index * Add configmap looper * fix * Update services * fix * Fixes * Fixes * updates * Use data from * fix * More details * debug container * debug container * Make env var * Revert debug * Inject certificates * Update dirk containers * rename * update configs * Add peer namespace * Try static peers * Redirect output to temp * Debug container * Debug container * Debug container * Restore dirk * Add ports * Make svc headless * Single svc * Full name * Add initial vouch * fix * fix * fix * fixes * Change default dir * Make vouch config configurable * Make vouch config configurable * Format fix * Format fix * Remove harcoded values * Add dirk loglevel * Add vouch execution config * fix * Add metrics ports * Add metrics ports * generation-passphrase is optional * make tmpfs sizefs size dynamic * remove pubkeys approach in lodestar validator * fetch keys from remote signer with ls val * revert * try re-adding rpcEndpoints * Make reloader false by default * Add tracing support * Add dirk tracing * Add missing migrations (#45) Co-authored-by: Marcos Antonio Maceo Reyes <marcosmaceowork@gmail.com> * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add scripts * Generate client1 certificates * update script * Change default init image * Change default init image * Generate certs * Add scripts to dirk * Update locations * Cleanup * Update dirk/vouch values * Drop hardcoded client1 from vouch * Add fetch-keys-syncer * Simplify dirk configmaps * Simplify dirk configmaps * Fixes * Fixes * Add debug info * Use bash * Add missing envsubst package * printenv * Use file path index * Fix * add exec * Remove comments * Simplify path * Multiple sts to 1 * Fix configs * No need for qoutes * Update cm * Add env configmap * Use disk persistence for dirk * Fix * Remove sleeper from Vouch * merge stuff from other branch * remove unused * remove extra secrets * minor fixes to template * consolidate eso * remove default eso value from eb * try to fix helper * fix * try to fix * fix * try diff approach * fix declaration * maybe this will work * fix * try sth else * remove helper * use predefined secrets only if nothing is provided * fixes * revert * fix * fix w3s endpoint * remove validate * minor fixes * remove port from w3s helper * fix helper * Add Dirk/Vouch charts (#46) * Test probe annotation * Change probe type * Add new provisioningExternalSecrets * Fix * Add provisioningExternalSecrets * Fix naming * Add reloader sidercar * Needs root * Remove network option * Test watcher container * Test watcher container * Test watcher container * Update watcher image * Multiline * Multiline * Multiline * Add poetry run keystore-cli * Add poetry run keystore-cli * Add diff checker * Add diff checker * Add livenessProbe * Add livenessProbe * Test exit * Expose pod name * Add kubectl delete * Update wait * Fix * Fix * Add wait * Add watcher.sh * Correct location * No root accessible * Update cm name * Extract to script * Add watcher scripts * Update watcher.sh * fixes * Add --no-of-keys as param * Add --no-of-keys as param * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * Add sigterm handler * Use bash wrapper * Simplify code * Init chart dirk * Remove main container for now * Remove not needed secrets * Remove old type secrets * Fix sleeping * Fix bash path * Change looper * Change looper * Change ranger * fix * fix * New range * New range * Fixes * Fixes * More replicas * More replicas * More replicas * Add 2 * Add 2 * fix * fix * fix * fix * Add missing separator * Add index * Add configmap looper * fix * Update services * fix * Fixes * Fixes * updates * Use data from * fix * More details * debug container * debug container * Make env var * Revert debug * Inject certificates * Update dirk containers * rename * update configs * Add peer namespace * Try static peers * Redirect output to temp * Debug container * Debug container * Debug container * Restore dirk * Add ports * Make svc headless * Single svc * Full name * Add initial vouch * fix * fix * fix * fixes * Change default dir * Make vouch config configurable * Make vouch config configurable * Format fix * Format fix * Remove harcoded values * Add dirk loglevel * Add vouch execution config * fix * Add metrics ports * Add metrics ports * generation-passphrase is optional * Make reloader false by default * Add tracing support * Add dirk tracing * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add scripts * Generate client1 certificates * update script * Change default init image * Change default init image * Generate certs * Add scripts to dirk * Update locations * Cleanup * Update dirk/vouch values * Drop hardcoded client1 from vouch * Add fetch-keys-syncer * Simplify dirk configmaps * Simplify dirk configmaps * Fixes * Fixes * Add debug info * Use bash * Add missing envsubst package * printenv * Use file path index * Fix * add exec * Remove comments * Simplify path * Multiple sts to 1 * Fix configs * No need for qoutes * Update cm * Add env configmap * Use disk persistence for dirk * Fix * Remove sleeper from Vouch * merge stuff from other branch * remove unused * remove extra secrets * minor fixes to template * consolidate eso * remove default eso value from eb * try to fix helper * fix * try to fix * fix * try diff approach * fix declaration * maybe this will work * fix * try sth else * remove helper * use predefined secrets only if nothing is provided * fixes * revert * fix * fix w3s endpoint * remove validate * minor fixes * remove port from w3s helper * fix helper --------- Co-authored-by: Aivaras Ko <aivaras.ko@gmail.com> * fix default values * Fix serviceAccountName * Fix serviceAccountName * Remove unlocker * Update tracing config * Update tracing config * Update tracing config * Fixes * Fixes * fix dirk * Remove not used vars * Temporary disable fetch-keys * Remove syncer * Disable syncer * fix * Fix * Revert syncer * Remove dirk fetch-keys init * Change default versions * Revert * Quick start * Restore * Make relays as a list * Add resources * Update rolling update strategy * Fix * Make minReadySeconds configurable * Set to default rollingUpdate strategy * Try different rollingUpdate strategy * Remove sts maxSurge * Set default rollingUpdate strategy * Add livenessProbe * Fix * Correct container * One failure restart * Add timeoutSeconds * Lower sleep time * Disable livenessProbe for now * New version * Fix location * Correct syntax? * Change * Test again * Remove seconds argument * Fix typo * Updates * Allow to override Vouch strategies and submitter * Add readinessProbe for Vouch * Add readinessProbe for Dirk * Allow to override full vouch config * Correct indent * Add topologySpreadConstraints * Fix * Introduce livenessProbe * Missing end statement * Change successThreshold * Tune readiness probes * Update values.yaml Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> * execution and beacon updates * cleaning up all charts, updating versions * update image tags * add fallbackRpcEndpoints and fix sharedPersistence init * add missing envFrom * add securityContext nonRoot * fix references * remove ownership changes * use root for init * trying out chiseled nm * fix execution commands and args * fix ends * fix env-nodeport * try static envs * fix variable scope * fix extra brackets * remove dataStorage settings for Teku * Merge prod-stable additions (#74) * feat: add lodestar (#56) * feat: add lodestar validator * refactor: remove hpa * fix: remove autoscaling * refactor: change bash to sh * feat: add http port and fix probes * feat: add rest for checks * chore: remove probes * Add envFrom to execution container (#67) * Add envFrom to execution container in case we have externalSecrets enabled * Set seq as part of the charts and not as a extraflag * clean up seq and mining extraData on nethermind execution charts * Remove space on charts * Fix peers not set propertly on statefulset for execution-beacon (#72) * Fix peers not set propertly on statefulset for execution-beacon * Switch to targetPeers * remove teku prune option * define upperbound peers for neku * add min targetPeers for teku lower bound --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Denis Policastro <denis.policastro@gmail.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> * Add ingress (#78) * Add ingress to execution-beacon * Set Service Type configurable * Add global.ingress values and test template generation * fix envFrom - redundant * Fix init container when p2p type is LoadBalancer (#79) * Fix init container when p2p type is LoadBalancer * Remove extra dash in POD_PREFIX_NAME variable * Fix syntax errors (#80) * Features/quantstamp audit cleanup prep (#81) * QS Audit, see PR for details/impacts * fix reference * fix configmap * revert chown on init due to init-nimbus issues * TWI-10 fixes * Added restrictions for dirk/vouch * Added more missing restrictions for containers * Taking updated configmap from cleanup-prep * Including changes from latest in cleanup-prep * changing to global * add staking-prefix to secrets * move security ctx to global in values, and move pod sctx to higher level * add defaults to init * fix values.yml * change defaults * move fsGroup to podSecurityContext level * move capabilities to the container level * remove root fs from pod level ctx * remove read only fs from w3s container * update mevboost stx * update stx for exec and beacon * add missing stx * change init.sh * check if chown is required * remove root fs from execution container * fix promrules * remove rootfs from beacon containers * add additonal default rules for nimbus and lodestar * use el flag instead * remove default sa from vals * fix sa * add stx to validators * fix values * use global * fixes * fix pubkeys * fix perms --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Mark Liu <mark@prove.com.au> * Add support for externalTrafficPolicy on execution-beacon svc (#82) * Fix erigon's metrics flags indentation * Generate non-nethermind extra flags when nethermind is not chosen * Remove quotes from Nethermind's extra flags * [ingress] Add support for defining target Service of backend (#86) * Let beacon use podSecurityContext instead of hardcoded (#88) * Fix jwtsecret path when hardcoded in values.yml (#87) --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Signed-off-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com> Co-authored-by: Aivaras Ko <aivaras.ko@gmail.com> Co-authored-by: Mateusz Jędrzejewski <mateusz.jedrzejewski@yahoo.pl> Co-authored-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Marcos Antonio Maceo Reyes <marcosmaceowork@gmail.com> Co-authored-by: Denis Policastro <denis.policastro@gmail.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> Co-authored-by: Mark Liu <mark@prove.com.au>
AntiD2ta
added a commit
that referenced
this pull request
Feb 19, 2024
* Add 2 * Add 2 * fix * fix * fix * fix * Add missing separator * Add index * Add configmap looper * fix * Update services * fix * Fixes * Fixes * updates * Use data from * fix * More details * debug container * debug container * Make env var * Revert debug * Inject certificates * Update dirk containers * rename * update configs * Add peer namespace * Try static peers * Redirect output to temp * Debug container * Debug container * Debug container * Restore dirk * Add ports * Make svc headless * Single svc * Full name * Add initial vouch * fix * fix * fix * fixes * Change default dir * Make vouch config configurable * Make vouch config configurable * Format fix * Format fix * Remove harcoded values * Add dirk loglevel * Add vouch execution config * fix * Add metrics ports * Add metrics ports * generation-passphrase is optional * make tmpfs sizefs size dynamic * remove pubkeys approach in lodestar validator * fetch keys from remote signer with ls val * revert * try re-adding rpcEndpoints * Make reloader false by default * Add tracing support * Add dirk tracing * Add missing migrations (#45) Co-authored-by: Marcos Antonio Maceo Reyes <marcosmaceowork@gmail.com> * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add scripts * Generate client1 certificates * update script * Change default init image * Change default init image * Generate certs * Add scripts to dirk * Update locations * Cleanup * Update dirk/vouch values * Drop hardcoded client1 from vouch * Add fetch-keys-syncer * Simplify dirk configmaps * Simplify dirk configmaps * Fixes * Fixes * Add debug info * Use bash * Add missing envsubst package * printenv * Use file path index * Fix * add exec * Remove comments * Simplify path * Multiple sts to 1 * Fix configs * No need for qoutes * Update cm * Add env configmap * Use disk persistence for dirk * Fix * Remove sleeper from Vouch * merge stuff from other branch * remove unused * remove extra secrets * minor fixes to template * consolidate eso * remove default eso value from eb * try to fix helper * fix * try to fix * fix * try diff approach * fix declaration * maybe this will work * fix * try sth else * remove helper * use predefined secrets only if nothing is provided * fixes * revert * fix * fix w3s endpoint * remove validate * minor fixes * remove port from w3s helper * fix helper * Add Dirk/Vouch charts (#46) * Test probe annotation * Change probe type * Add new provisioningExternalSecrets * Fix * Add provisioningExternalSecrets * Fix naming * Add reloader sidercar * Needs root * Remove network option * Test watcher container * Test watcher container * Test watcher container * Update watcher image * Multiline * Multiline * Multiline * Add poetry run keystore-cli * Add poetry run keystore-cli * Add diff checker * Add diff checker * Add livenessProbe * Add livenessProbe * Test exit * Expose pod name * Add kubectl delete * Update wait * Fix * Fix * Add wait * Add watcher.sh * Correct location * No root accessible * Update cm name * Extract to script * Add watcher scripts * Update watcher.sh * fixes * Add --no-of-keys as param * Add --no-of-keys as param * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * No need for bash wrapper * Add sigterm handler * Use bash wrapper * Simplify code * Init chart dirk * Remove main container for now * Remove not needed secrets * Remove old type secrets * Fix sleeping * Fix bash path * Change looper * Change looper * Change ranger * fix * fix * New range * New range * Fixes * Fixes * More replicas * More replicas * More replicas * Add 2 * Add 2 * fix * fix * fix * fix * Add missing separator * Add index * Add configmap looper * fix * Update services * fix * Fixes * Fixes * updates * Use data from * fix * More details * debug container * debug container * Make env var * Revert debug * Inject certificates * Update dirk containers * rename * update configs * Add peer namespace * Try static peers * Redirect output to temp * Debug container * Debug container * Debug container * Restore dirk * Add ports * Make svc headless * Single svc * Full name * Add initial vouch * fix * fix * fix * fixes * Change default dir * Make vouch config configurable * Make vouch config configurable * Format fix * Format fix * Remove harcoded values * Add dirk loglevel * Add vouch execution config * fix * Add metrics ports * Add metrics ports * generation-passphrase is optional * Make reloader false by default * Add tracing support * Add dirk tracing * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add dirk.fetchKeysExtraFlags * Add scripts * Generate client1 certificates * update script * Change default init image * Change default init image * Generate certs * Add scripts to dirk * Update locations * Cleanup * Update dirk/vouch values * Drop hardcoded client1 from vouch * Add fetch-keys-syncer * Simplify dirk configmaps * Simplify dirk configmaps * Fixes * Fixes * Add debug info * Use bash * Add missing envsubst package * printenv * Use file path index * Fix * add exec * Remove comments * Simplify path * Multiple sts to 1 * Fix configs * No need for qoutes * Update cm * Add env configmap * Use disk persistence for dirk * Fix * Remove sleeper from Vouch * merge stuff from other branch * remove unused * remove extra secrets * minor fixes to template * consolidate eso * remove default eso value from eb * try to fix helper * fix * try to fix * fix * try diff approach * fix declaration * maybe this will work * fix * try sth else * remove helper * use predefined secrets only if nothing is provided * fixes * revert * fix * fix w3s endpoint * remove validate * minor fixes * remove port from w3s helper * fix helper --------- Co-authored-by: Aivaras Ko <aivaras.ko@gmail.com> * fix default values * Fix serviceAccountName * Fix serviceAccountName * Remove unlocker * Update tracing config * Update tracing config * Update tracing config * Fixes * Fixes * fix dirk * Remove not used vars * Temporary disable fetch-keys * Remove syncer * Disable syncer * fix * Fix * Revert syncer * Remove dirk fetch-keys init * Change default versions * Revert * Quick start * Restore * Make relays as a list * Add resources * Update rolling update strategy * Fix * Make minReadySeconds configurable * Set to default rollingUpdate strategy * Try different rollingUpdate strategy * Remove sts maxSurge * Set default rollingUpdate strategy * Add livenessProbe * Fix * Correct container * One failure restart * Add timeoutSeconds * Lower sleep time * Disable livenessProbe for now * New version * Fix location * Correct syntax? * Change * Test again * Remove seconds argument * Fix typo * Updates * Allow to override Vouch strategies and submitter * Add readinessProbe for Vouch * Add readinessProbe for Dirk * Allow to override full vouch config * Correct indent * Add topologySpreadConstraints * Fix * Introduce livenessProbe * Missing end statement * Change successThreshold * Tune readiness probes * Update values.yaml Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> * execution and beacon updates * cleaning up all charts, updating versions * update image tags * add fallbackRpcEndpoints and fix sharedPersistence init * add missing envFrom * add securityContext nonRoot * fix references * remove ownership changes * use root for init * remove dataStorage settings for Teku * Merge prod-stable additions (#74) * feat: add lodestar (#56) * feat: add lodestar validator * refactor: remove hpa * fix: remove autoscaling * refactor: change bash to sh * feat: add http port and fix probes * feat: add rest for checks * chore: remove probes * Add envFrom to execution container (#67) * Add envFrom to execution container in case we have externalSecrets enabled * Set seq as part of the charts and not as a extraflag * clean up seq and mining extraData on nethermind execution charts * Remove space on charts * Fix peers not set propertly on statefulset for execution-beacon (#72) * Fix peers not set propertly on statefulset for execution-beacon * Switch to targetPeers * remove teku prune option * define upperbound peers for neku * add min targetPeers for teku lower bound --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Denis Policastro <denis.policastro@gmail.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> * Features/quantstamp audit cleanup prep (#81) * QS Audit, see PR for details/impacts * fix reference * fix configmap * revert chown on init due to init-nimbus issues * TWI-10 fixes * Added restrictions for dirk/vouch * Added more missing restrictions for containers * Taking updated configmap from cleanup-prep * Including changes from latest in cleanup-prep * changing to global * add staking-prefix to secrets * move security ctx to global in values, and move pod sctx to higher level * add defaults to init * fix values.yml * change defaults * move fsGroup to podSecurityContext level * move capabilities to the container level * remove root fs from pod level ctx * remove read only fs from w3s container * update mevboost stx * update stx for exec and beacon * add missing stx * change init.sh * check if chown is required * remove root fs from execution container * fix promrules * remove rootfs from beacon containers * add additonal default rules for nimbus and lodestar * use el flag instead * remove default sa from vals * fix sa * add stx to validators * fix values * use global * fixes * fix pubkeys * fix perms --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Mark Liu <mark@prove.com.au> * Start using Nethermind chiseled image (#75) * trying out chiseled nm * fix execution commands and args * fix ends * fix env-nodeport * try static envs * fix variable scope * fix extra brackets * Add ingress (#78) * Add ingress to execution-beacon * Set Service Type configurable * Add global.ingress values and test template generation * fix envFrom - redundant * Fix init container when p2p type is LoadBalancer (#79) * Fix init container when p2p type is LoadBalancer * Remove extra dash in POD_PREFIX_NAME variable * Fix syntax errors (#80) * Add support for externalTrafficPolicy on execution-beacon svc (#82) * Fix erigon's metrics flags indentation * Generate non-nethermind extra flags when nethermind is not chosen * Remove quotes from Nethermind's extra flags --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Signed-off-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com> Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com> Co-authored-by: AntiD2ta <mtpotro41@gmail.com> * Revert "Start using Nethermind chiseled image (#75)" This reverts commit 7149531. * Add chart maintainers * Add CODEOWNERS * Add codeowners checker workflow * Add workflow to validate PRs correctness * Add linter (super-linter) * Lint and test charts with kind and chart-testing * Update release pipeline * Update some charts descriptions * Make scripts executable in the workflows * Update validator-kapi Chart.lock * Fix linter reported issues * Update validate-pr workflow * Install Helm dependencies in lint-test workflow * Update CODEOWNERS * Fix linter issues with bash scripts * Update Helm dependencies in workflows * Fix linter issues with check-codeowners.sh * Bump chart versions * Update dirk dependencies * Fix linter issues with validate-pr.sh * Fix securityContext linter issues with dirk and vouch * Fix ct lint issues on charts * Add Makefile * Bump rpc-saas-secretStore version * Bump juno-chart version * Fix password leak on validator-kapi * Use a chart-testing config file * Try to skip gitleaks keyword for secret reference * Add gitleaks config * Solve super-linter issues * Add external secrets dependency to charts-testing * Add gitleaks allow comments * Skip ct install * Update lodestar chart maintainers * Move dirk securityContext under Values.Global * Fix linter issues * Add READMEs to charts * Add CI check for documentation update * Fix linter issues * Fix linter issues * Update juno-charts README * Add docs rule to Makefile * Fix juno-node lint issues * Update CODEOWNERS * Add Contributing guidelines * Attempt to fix angkor-validator-operators ref in CODEOWNERS * Fix superliner issues on Contributing guidelines * ci: Add conventional commits checker --------- Signed-off-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Signed-off-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com> Co-authored-by: Aivaras Ko <aivaras.ko@gmail.com> Co-authored-by: Mateusz Jędrzejewski <mateusz.jedrzejewski@yahoo.pl> Co-authored-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Marcos Antonio Maceo Reyes <marcosmaceowork@gmail.com> Co-authored-by: Denis Policastro <denis.policastro@gmail.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> Co-authored-by: Mark Liu <mark@prove.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
targetPeerswas not set for beacon nodes, were set usingtargetPeersMap.targetPeersMap is set here.