This repository was archived by the owner on Dec 12, 2023. It is now read-only.
add keys relative to home folder#118
Merged
Merged
Conversation
shrimalmadhur
requested review from
AntiD2ta,
adriantpaez,
bowenli86,
cryptogakusei,
jianoaix and
samlaf
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AntiD2ta
previously requested changes
Oct 17, 2023
Contributor
AntiD2ta
left a comment
AntiD2ta
left a comment
There was a problem hiding this comment.
Please update the changelog. The rest LGTM
samlaf
reviewed
Oct 17, 2023
shrimalmadhur
dismissed
AntiD2ta’s stale review
Added change log and got another approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
#109
Changes:
Types of changes
Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.
Testing
Requires testing Yes/No
In case you checked yes, did you write tests? Yes/No
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...