This repository was archived by the owner on Dec 12, 2023. It is now read-only.
Update docs based on feedback#137
Merged
Merged
Conversation
shrimalmadhur
requested review from
AntiD2ta,
adriantpaez,
bowenli86,
cryptogakusei,
dmanc,
jianoaix and
samlaf
as code owners
shrimalmadhur
force-pushed
the
madhur/documentation
branch
from
605858b to
3d7e9b8
Compare
bowenli86
approved these changes
Nov 6, 2023
bowenli86
left a comment
bowenli86
left a comment
There was a problem hiding this comment.
lgtm
btw, I think such small updates can be checked in directly in future for faster iteration speed, no review needed
Collaborator
Author
apparently there's some weird go dependency issue I am trying to resolve. will ask for review later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Updating docs based on feedback
Changes:
Types of changes
Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.
Testing
Requires testing Yes/No
In case you checked yes, did you write tests? Yes/No
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...