Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

Plugin: local path & --build-arg#52

Merged
AntiD2ta merged 10 commits into
developfrom
feat/plugin
Aug 16, 2023
Merged

Plugin: local path & --build-arg#52
AntiD2ta merged 10 commits into
developfrom
feat/plugin

Conversation

@adriantpaez
Copy link
Copy Markdown
Contributor

@adriantpaez adriantpaez commented Aug 9, 2023

Changes:

  • Support relative path for plugin installation.
  • Add the --build-arg flag to the plugin command, to pass arguments to the plugin image build process.

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing Yes

In case you checked yes, did you write tests? Yes

Comment thread internal/data/instance.go Outdated
Comment thread internal/data/instance_test.go
Comment thread internal/data/instance_test.go Outdated
Comment thread internal/data/instance_test.go
Comment thread internal/docker/docker.go Outdated
Comment thread internal/docker/docker.go
Comment thread internal/docker/docker.go
Comment thread internal/package_handler/manifest.go Outdated
Comment thread internal/docker/docker.go
Comment thread pkg/daemon/error.go
Comment thread pkg/daemon/egn_daemon_test.go
Comment thread pkg/daemon/egn_daemon.go
@adriantpaez adriantpaez changed the title Plugin with relative path Plugin: local path & --build-arg Aug 10, 2023
@adriantpaez adriantpaez marked this pull request as ready for review August 15, 2023 22:48
Comment thread e2e/checks.go Outdated
@adriantpaez adriantpaez added the enhancement New feature or request label Aug 16, 2023
@adriantpaez adriantpaez requested a review from AntiD2ta August 16, 2023 09:15
Comment thread e2e/plugin_test.go
Comment thread e2e/plugin_test.go Outdated
Comment thread e2e/plugin_test.go
Comment thread e2e/plugin_test.go
Comment thread e2e/docker/events.go
Comment thread e2e/docker/events.go
Comment thread e2e/docker/events.go
Comment thread e2e/plugin_test.go Outdated
Copy link
Copy Markdown
Contributor

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@AntiD2ta AntiD2ta merged commit c776b4e into develop Aug 16, 2023
@AntiD2ta AntiD2ta deleted the feat/plugin branch August 16, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants