This repository was archived by the owner on Dec 12, 2023. It is now read-only.
Fix and update post-installation cleanup#54
Merged
Conversation
Changes: - Move local-install tests to a new file - Enhance checks for installed instance - Add check for temp directory - Add tests for post-install cleanup
adriantpaez
reviewed
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-installation cleanup was failing for some branch cases of the
local-installflow. Fixing this provoked a new issue in the cleanup when trying to install an already-installed instance. This resulted in a refactor of the entire installation process and upgrading the E2E tests.Changes:
Types of changes
Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.
Testing
Requires testing Yes
In case you checked yes, did you write tests? Yes