Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

Update mock avs links#74

Merged
AntiD2ta merged 4 commits into
developfrom
update-mock-avs-links
Sep 14, 2023
Merged

Update mock avs links#74
AntiD2ta merged 4 commits into
developfrom
update-mock-avs-links

Conversation

@AntiD2ta
Copy link
Copy Markdown
Contributor

Changes:

  • Update mock-avs:
    • Links
    • Tag version
    • Usage in tests
  • Use manifest.name for Instance ID.

Types of changes

Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)

Testing

Requires testing Yes

In case you checked yes, did you write tests? Yes

@AntiD2ta AntiD2ta self-assigned this Sep 13, 2023
Copy link
Copy Markdown
Contributor

@adriantpaez adriantpaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some test cases use const variables for the repo URL and version, while others do not. Do you think this is something we should enforce in all tests? If so, we could create an internal/mock_avs package that contains all the const values related to the mock-avs and mock-avs-pkg repositories for easy access in the tests

Comment thread cli/install_test.go Outdated
Comment thread cli/install_test.go Outdated
Comment thread cli/install_test.go
Comment thread cli/ls_test.go
Comment thread cli/utils_test.go
Comment thread internal/data/datadir_test.go Outdated
@adriantpaez
Copy link
Copy Markdown
Contributor

I really like this new package for the mock-avs version management, nice!

@AntiD2ta AntiD2ta merged commit 4c42589 into develop Sep 14, 2023
@AntiD2ta AntiD2ta deleted the update-mock-avs-links branch September 14, 2023 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants