Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the benchmark suite by optimizing execution time and increasing test coverage. The changes restructure the benchmark job configurations and expand test value variants to exercise more code paths.
Key changes include:
- Reduced benchmark job iterations (launchCount: 1, warmupCount: 3, iterationCount: 5) and removed MemoryDiagnoser to speed up execution
- Expanded test value variants from 2 to 5 different size categories (UInt256Max-1, UInt192Max-1, UInt128Max-1, TwoTo64-1, One) for better code path coverage
- Converted to file-scoped namespace declaration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/Nethermind.Int256.Benchmark/Nethermind.Int256.Benchmark.csproj | Adds exclusion of BenchmarkDotNet.Artifacts directory from compilation to prevent build issues |
| src/Nethermind.Int256.Benchmark/Benchmarks.cs | Refactors all benchmark classes with optimized job configurations, increased test value variants, file-scoped namespace, and restructured base class hierarchy |
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase variants and paths taken
Improve time taken