Skip to content

fix: some of clippy pedantic warnings#209

Closed
varex83 wants to merge 10 commits into
bohdan/add-connection-loggerfrom
bohdan/fix-pedantic-clippy-warnings
Closed

fix: some of clippy pedantic warnings#209
varex83 wants to merge 10 commits into
bohdan/add-connection-loggerfrom
bohdan/fix-pedantic-clippy-warnings

Conversation

@varex83
Copy link
Copy Markdown
Collaborator

@varex83 varex83 commented Feb 5, 2026

This PR fixes most of the clippy::pedantic warnings:

cargo clippy --workspace --all-targets --all-features --exclude pluto-eth2api --fix  -- -W clippy::pedantic -A clippy::missing_errors_doc

also, replace some of the builders with bon

@emlautarom1
Copy link
Copy Markdown
Collaborator

Is this PR intentionally targeting your bohdan/add-connection-logger branch?

Copy link
Copy Markdown
Collaborator

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't think we want to generally enable pedantic in the codebase since some suggestions end up being quite annoying (ex. prefer method reference over method call), but instead we should evaluate them individually (ex. always using underscores for large numbers sounds reasonable enough).

Comment thread crates/p2p/src/k1.rs
Comment on lines +32 to +35
///
/// # Errors
///
/// - [`K1Error::K1UtilError`] if the private key cannot be loaded.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to go the route of adding this docs into all Result functions: it will get annoying quite quickly and provides little actual value.

Same for panics.

@emlautarom1
Copy link
Copy Markdown
Collaborator

Does this PR make sense with the changes to #202 ?

@varex83
Copy link
Copy Markdown
Collaborator Author

varex83 commented Feb 24, 2026

Does this PR make sense with the changes to #202 ?

No, I'm closing it since creating a new one will be easier than fixing merge conflicts.

@varex83 varex83 closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants