fix: some of clippy pedantic warnings#209
Conversation
|
Is this PR intentionally targeting your |
emlautarom1
left a comment
There was a problem hiding this comment.
LGTM.
I don't think we want to generally enable pedantic in the codebase since some suggestions end up being quite annoying (ex. prefer method reference over method call), but instead we should evaluate them individually (ex. always using underscores for large numbers sounds reasonable enough).
| /// | ||
| /// # Errors | ||
| /// | ||
| /// - [`K1Error::K1UtilError`] if the private key cannot be loaded. |
There was a problem hiding this comment.
I don't think we want to go the route of adding this docs into all Result functions: it will get annoying quite quickly and provides little actual value.
Same for panics.
|
Does this PR make sense with the changes to #202 ? |
No, I'm closing it since creating a new one will be easier than fixing merge conflicts. |
This PR fixes most of the
clippy::pedanticwarnings:also, replace some of the builders with
bon