Skip to content

feat(eth2util): implement keymanager#241

Merged
iamquang95 merged 4 commits into
mainfrom
iamquang95/eth2util/keymanager-3
Feb 24, 2026
Merged

feat(eth2util): implement keymanager#241
iamquang95 merged 4 commits into
mainfrom
iamquang95/eth2util/keymanager-3

Conversation

@iamquang95
Copy link
Copy Markdown
Collaborator

Should fix: #166

Copy link
Copy Markdown
Collaborator

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would only add that it would be nice to have integration tests that ping a real CL. You can copy the pattern in eth2_api for that.

Also, given the scope of the feature it does not really make sense, but in the future we could extend the eth2_api crate with the schema defined in https://ethereum.github.io/keymanager-APIs/ since it contains the endpoints and types used by this feature.

Comment thread crates/eth2util/src/keymanager.rs
@iamquang95
Copy link
Copy Markdown
Collaborator Author

Also, given the scope of the feature it does not really make sense, but in the future we could extend the eth2_api crate with the schema defined in https://ethereum.github.io/keymanager-APIs/ since it contains the endpoints and types used by this feature.

It's maybe a bit extra for the current scope since we only need 1 api from that. Will add it later in the future when we have more API usages

@iamquang95 iamquang95 merged commit f591041 into main Feb 24, 2026
5 checks passed
@iamquang95 iamquang95 deleted the iamquang95/eth2util/keymanager-3 branch February 24, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement eth2util/keymanager

2 participants