feat: implement `cluster/helpers` by emlautarom1 · Pull Request #272 · NethermindEth/pluto

emlautarom1 · 2026-03-05T17:17:18Z

Closes #246

Ended up requiring a bit more code than I initially expected due to the test_cluster module. This helped find some issues in existing code though.

- Avoids clone, allows more usages

- No need for ownership - More flexible when dealing with slices

- Our impl does not use 1-index for shares

- Matches the Go implementation

- Test for valid, invalid and non 200 responses

- Test code only

emlautarom1 · 2026-03-05T17:18:16Z

+            timestamp: chrono::Local::now()
+                .with_nanosecond(0)
+                .expect("nanoseconds = 0")
+                .to_rfc3339(),


This is required to match the Go implementation: requires TZ and explicitly set nanoseconds to 0, otherwise the string gets too long and SSZ serialization fails (exceeds 32 byte limit)

emlautarom1 · 2026-03-05T17:19:37Z

+        let mut priv_shares: Vec<pluto_crypto::types::PrivateKey> = Vec::new();
+
+        for i in 0..n {
+            let share_priv_key = *shares.get(&i).unwrap(); // NOTE: Pluto implementation does not use 1-based indexing for shares


This is also a tricky point that caused me some issues while debugging: the shares produced by blst.threshold_split_insecure are NOT indexed from 1 unlike the Go implementation.

cc. @varex83

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

- Fixes issues with streaming responses

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

…elpers

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

- Slight deviation from the original code but better for debugging

varex83

LGTM

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

emlautarom1 added 20 commits March 4, 2026 12:33

Add random_eth_address_seed

19bfe73

Make Record::new accept argument as ref

0c3c579

- Avoids clone, allows more usages

Prefer to use &[] as argument

76df81a

- No need for ownership - More flexible when dealing with slices

Prefer impl AsRef<str> when possible

d4a1177

Prefer &mut over ownership

6dc0d60

Expose function

52bcd30

Use inner data directly

129859a

Initial test_cluster

a28dffc

Add missing ref

0f556cc

Apply clippy suggestions

04ec923

Remove +1

0cfe82d

- Our impl does not use 1-index for shares

Make now be local without nanos

42a6ba8

- Matches the Go implementation

Add fetch_definition

25bb2a7

- Test for valid, invalid and non 200 responses

Update lockfile

c33ef86

Fix formatting

09a4b97

Fix clippy suggestions

4e441af

Remove import

0b26324

Ignore clippy warning

8aa7a25

- Test code only

Add create_validator_keys_dir

bb230ab

Make signature more generic

41fde25

Copilot AI review requested due to automatic review settings March 5, 2026 17:17

emlautarom1 commented Mar 5, 2026

View reviewed changes

emlautarom1 requested review from iamquang95 and varex83 March 5, 2026 17:21

Merge branch 'main' into emlautarom1/cluster-helpers

0213e47

Copilot AI reviewed Mar 5, 2026

View reviewed changes

emlautarom1 requested a review from Copilot March 5, 2026 20:14

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Apply timeout to the entire operation

9bbe2eb

- Fixes issues with streaming responses

Copilot AI review requested due to automatic review settings March 10, 2026 11:41

Copilot started reviewing on behalf of emlautarom1 March 10, 2026 11:41 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread crates/cluster/src/test_cluster.rs

emlautarom1 force-pushed the emlautarom1/cluster-helpers branch from 2808a91 to 0ada038 Compare March 10, 2026 12:00

emlautarom1 added 2 commits March 10, 2026 09:01

Merge remote-tracking branch 'origin/main' into emlautarom1/cluster-h…

7594a3c

…elpers

Fix clippy warnings

27d5241

Copilot AI review requested due to automatic review settings March 10, 2026 12:02

Copilot started reviewing on behalf of emlautarom1 March 10, 2026 12:03 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread crates/eth2util/src/network.rs

Comment thread crates/cluster/src/test_cluster.rs

emlautarom1 requested review from Copilot and iamquang95 March 11, 2026 15:23

Copilot started reviewing on behalf of emlautarom1 March 11, 2026 15:24 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Comment thread crates/cluster/Cargo.toml Outdated

Comment thread crates/cluster/src/test_cluster.rs Outdated

emlautarom1 added 2 commits March 11, 2026 18:04

Improve random management

ca177d9

- Slight deviation from the original code but better for debugging

Use explicit reqwest features

86cd6c4

iamquang95 approved these changes Mar 12, 2026

View reviewed changes

varex83 approved these changes Mar 12, 2026

View reviewed changes

emlautarom1 added 6 commits March 12, 2026 11:05

Fix typo

3055450

Use helpers::to_0x_hex

9d174eb

Use Vec::with_capacity

75637ba

Use test cluster as name

e8e11f0

Remove qualified use

971afcd

Fix clippy lints

d38831a

Copilot AI review requested due to automatic review settings March 12, 2026 14:26

Copilot started reviewing on behalf of emlautarom1 March 12, 2026 14:27 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread crates/cluster/src/test_cluster.rs

Comment thread crates/cluster/src/helpers.rs

emlautarom1 merged commit b6e9008 into main Mar 12, 2026
13 checks passed

emlautarom1 deleted the emlautarom1/cluster-helpers branch March 12, 2026 17:08

PoulavBhowmick03 approved these changes Mar 12, 2026

View reviewed changes

Comment thread crates/cluster/src/helpers.rs

varex83 mentioned this pull request Mar 13, 2026

fix: make 1-based indexing in tbls implementation #279

Merged

Conversation

emlautarom1 commented Mar 5, 2026

Uh oh!

emlautarom1 Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

emlautarom1 Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varex83 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

emlautarom1 Mar 5, 2026 •

edited

Loading