fix: increase deadliner test timing#324
Merged
Merged
Conversation
The test_deadliner test used 10ms-per-slot deadline margins, which could be exceeded by wall-clock time elapsed between capturing start_time and the background task processing add() on loaded CI runners, causing non-expired duties to appear expired. Increase to 500ms per slot and raise the collection timeout to 5s. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pinebit
changed the title
Collaborator
varex83
approved these changes
Apr 15, 2026
Collaborator
varex83
left a comment
varex83
left a comment
There was a problem hiding this comment.
Yes, I think we can use this approach as a workaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_deadlinertest used 10ms-per-slot deadline margins, creating a race condition: wall-clock time elapsed between capturingstart_timeand the background task processingadd()could exceed the deadline on loaded CI runners, making "non-expired" duties appear expired.Test plan
cargo test --package pluto-core deadline::tests::test_deadlinerpassescargo +nightly fmt --all --checkcleancargo clippy --package pluto-core --all-targets --all-features -- -D warningsclean🤖 Generated with Claude Code