fix: ignore stale OutboundFailure events in bcast behaviour#336
Merged
iamquang95 merged 1 commit intoApr 16, 2026
Merged
Conversation
iamquang95
approved these changes
Apr 16, 2026
Collaborator
|
@iamquang95 Any chance we could add a test for this edge case, or is it very complicated to reproduce? |
Collaborator
|
@emlautarom1 let me try to add an unit test for this scenario |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OutboundFailurefrom a previously failed broadcast could kill a subsequent active broadcastcomplete_active_broadcast, taking down whatever broadcast was active at that pointop_idbelongs to the current broadcast before acting. If it doesn't match, the event is logged and ignored — consistent with howSigResponseandMessageSentalready handle stale eventsTest plan
cargo clippy --workspace --all-targets --all-features -- -D warningspassescargo +nightly fmt --all --checkpassescargo test --workspace --all-featurespasses