refactor(p2p): not allow builder to set p2p_context#348
Merged
iamquang95 merged 4 commits intomainfrom Apr 24, 2026
Merged
Conversation
Collaborator
|
Looks like a reasonable solution, 👍 |
…ault-p2pcontext-v2
varex83
reviewed
Apr 23, 2026
| let relay_config = create_relay_config(config); | ||
| // Relay servers don't track cluster peers - they serve all connections | ||
| let known_peers: Vec<libp2p::PeerId> = vec![]; | ||
| let p2p_context = P2PContext::default(); |
Collaborator
There was a problem hiding this comment.
I think you can inline this into new_server function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a
P2PContextownership misuseAPI in the P2P builder flow.Previously,
Node::newcreated aP2PContextinternally while callers could also create one externally andPlutoBehaviourBuildercould overwrite it again. That made it possible forNode,PlutoBehaviour, and inner behaviours to accidentally use different contexts.This change makes
P2PContextan explicit constructor input toNode::new/Node::new_server, removeswith_p2p_contextfrom the builder, and moves local peer binding intoNode.Benefit: one node now has one authoritative shared
P2PContext, making the API safer and preventing split state between node-level and behaviour-level components.