fix: silence all logging/tracing in tests#357
Merged
Conversation
- Avoids cluttering test output with logs Co-authored-by: Copilot <copilot@github.com>
iamquang95
approved these changes
Apr 29, 2026
mskrzypkows
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests utilize the
runfunctions exposed by the CLI commands, yet some of these functions initialize thepluto_tracingmodule, resulting in logs cluttering stdout when running the tests (cargo test). For example:pluto/crates/cli/src/commands/test/infra.rs
Lines 552 to 562 in ae0f152
This PR addresses this issue, ensuring that the
pluto_tracingmodule is initialized only inmainfor which we don't have tests (and we don't intend to have either).