fix: verify dkg runner output semantic#378
Merged
iamquang95 merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
varex83
approved these changes
May 8, 2026
iamquang95
force-pushed
the
iamquang95/verify-semantic
branch
from
0fe306c to
1ad13eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification changes
Replaces the old output check, which only verified that each node produced a non-empty
cluster-lock.jsonand at least one keystore, with semantic validation of the generated DKG artifacts.New verification checks that all nodes produced equivalent locks, expected operator/validator counts, threshold, lock hash/signature shapes, node signatures, unique validator pubkeys, deposit data/pubkey consistency, builder registration consistency, public shares, and per-node keystores matching the expected public shares.
A runtime smoke check now also starts Charon from the generated artifacts by default, proving the outputs are usable beyond static file presence.