feat: add create cluster sem checks#388
Merged
Merged
Conversation
iamquang95
reviewed
May 11, 2026
| FEE_RECIPIENT_ADDRESS="0xDeaDbeefdEAdbeefdEadbEEFdeadbeEFdEaDbeeF" | ||
| WITHDRAWAL_ADDRESS="0xDeaDbeefdEAdbeefdEadbEEFdeadbeEFdEaDbeeF" | ||
|
|
||
| EXACT=0 |
Collaborator
There was a problem hiding this comment.
Can the exact work? since the seed for charon and pluto will be different.
iamquang95
reviewed
May 11, 2026
Comment on lines
+16
to
+26
| if [[ -z "${PLUTO_BIN:-}" ]]; then | ||
| PLUTO_BIN="${ROOT_DIR}/target/debug/pluto" | ||
| fi | ||
|
|
||
| if [[ -z "${CHARON_BIN:-}" ]]; then | ||
| if [[ -x "${ROOT_DIR}/../charon/charon" ]]; then | ||
| CHARON_BIN="${ROOT_DIR}/../charon/charon" | ||
| else | ||
| CHARON_BIN="charon" | ||
| fi | ||
| fi |
Collaborator
There was a problem hiding this comment.
should expect to set the path, the ../charon seems a bit off. Also the charon_bin should be required, otherwise we can run with different version of charon.
Removed the silent ../charon/charon and PATH fallbacks for CHARON_BIN so runs cannot pick up a stale or mismatched charon version, and removed the --exact mode since charon and pluto draw randomness from independent CSPRNGs and cannot produce byte-identical locks. Co-authored-by: varex83 <varex83@users.noreply.github.com>
iamquang95
approved these changes
May 18, 2026
Collaborator
|
@varex83 Could yo elaborate on what this PR achieves? It's not used on CI or any other place. When should we run this script? Should it be part of the test suite? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.