Skip to content

Conversation

@khalifaa55
Copy link
Contributor

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@khalifaa55 khalifaa55 requested a review from stdevMac November 12, 2025 13:57
@khalifaa55 khalifaa55 self-assigned this Nov 12, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.69%. Comparing base (eafaa91) to head (bab2758).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #533   +/-   ##
========================================
  Coverage    23.69%   23.69%           
========================================
  Files          121      121           
  Lines        19671    19671           
========================================
  Hits          4662     4662           
  Misses       14472    14472           
  Partials       537      537           
Flag Coverage Δ
unittests 23.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khalifaa55 khalifaa55 merged commit d0271c7 into develop Nov 12, 2025
11 of 12 checks passed
@khalifaa55 khalifaa55 deleted the feat/lido-goo branch November 12, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants