Skip to content

privsep: Allow __NR__llseek as well as __NR_llseek on linux - #696

Merged
rsmarples merged 1 commit into
masterfrom
nr__llseek
Aug 12, 2026
Merged

privsep: Allow __NR__llseek as well as __NR_llseek on linux#696
rsmarples merged 1 commit into
masterfrom
nr__llseek

Conversation

@rsmarples

Copy link
Copy Markdown
Member

I have no idea why this has an extra _
Fixes pidfile cleanup on x86 Debian Bookworm.

I have no idea why this has an extra _
Fixes pidfile cleanup on x86 Debian Bookworm.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39bd6316-83b3-4be8-9611-24c200b752c4

📥 Commits

Reviewing files that changed from the base of the PR and between 8d499db and 78429f5.

📒 Files selected for processing (1)
  • src/privsep-linux.c

Walkthrough

The Linux seccomp syscall allowlist now conditionally permits __NR__llseek when the syscall macro is available.

Changes

Seccomp allowlist

Layer / File(s) Summary
Conditional __NR__llseek permission
src/privsep-linux.c
The seccomp allowlist permits __NR__llseek when the macro is defined.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the syscall allowlist change for both Linux syscall identifiers.
Description check ✅ Passed The description explains the extra underscore and identifies the pidfile cleanup fix on x86 Debian Bookworm.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nr__llseek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rsmarples
rsmarples merged commit 7c87dfd into master Aug 12, 2026
22 checks passed
@rsmarples
rsmarples deleted the nr__llseek branch August 12, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants