DHCP: script reason should be RELEASE on RELEASE, not STOP

[rsmarples]

Fixes #684.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be09bfa6-e75b-40cb-9b9c-32ce5056265f

📥 Commits

Reviewing files that changed from the base of the PR and between b83fe28 and 42307ab.

📒 Files selected for processing (1)

• src/dhcp.c

---

Walkthrough

dhcp_deconfigure now stores "RELEASE" in state->reason and passes that field to the deconfiguration script. The local reason variable and its conditional copy are removed.

Changes

DHCP deconfiguration reason handling

Layer / File(s)	Summary
Use state reason consistently src/dhcp.c	dhcp_deconfigure removes the local reason variable, assigns "RELEASE" directly to state->reason, and passes state->reason to the deconfiguration script.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 42307

This is a small, localized DHCP behavior correction with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

Possibly related PRs

• NetworkConfiguration/dhcpcd#589: Both changes modify dhcp_deconfigure() reason assignment and script invocation.
• NetworkConfiguration/dhcpcd#687: Both changes modify dhcp_deconfigure in src/dhcp.c.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states that the DHCP script reason changes to RELEASE during lease release.
Description check	✅ Passed	The description identifies issue #684, which directly relates to the DHCP lease release fix.
Linked Issues check	✅ Passed	The change assigns RELEASE during DHCP lease release, which addresses issue #684 and enables the timesyncd hook cleanup.
Out of Scope Changes check	✅ Passed	The changes are limited to the DHCP release reason and are directly related to issue #684.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch release

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}