Save demonstration files atomically - #56
Closed
eust-w wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Demo.save currently writes directly to the final path. If serialization is interrupted, the process crashes, or the filesystem returns an error, an existing demonstration can be truncated or replaced by a partial file.
Saving in the same directory and using os.replace keeps the previous demonstration intact until a complete safetensors file is ready. This is especially useful for long visual demonstrations, where recollection is expensive.
Compatibility
There is no public API or safetensors schema change. DemoRecorder.save_demo continues to return the same final path, and errors still propagate to the caller.
Validation