Skip to content

Conversation

@samuelgarcia
Copy link
Contributor

This remove the systematic import od datalad which can be annoying in notebook for some version because it trigger lot of errors.
datalad will be now imported on demand only.

@pep8speaks
Copy link

pep8speaks commented Jul 1, 2022

Hello @samuelgarcia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 41:1: E722 do not use bare 'except'

Line 33:1: E722 do not use bare 'except'

Line 18:5: E722 do not use bare 'except'

Comment last updated at 2022-07-01 12:42:48 UTC

@JuliaSprenger
Copy link
Member

Hi Samuel, I am a bit confused as in the title it sounds like you only want to import datalad in download_dataset, but your changes try to import datalad also in multiple other modules.
Maybe a better approach would be to try to download the dataset and catch the datalad missing exception when this fails?

@samuelgarcia
Copy link
Contributor Author

the try .. except is only at in subfolder tests.
The only real place is in the function.

@JuliaSprenger
Copy link
Member

Ok, I will merge this as soon as the tests are completed.

@JuliaSprenger JuliaSprenger merged commit a0bba3a into NeuralEnsemble:master Jul 1, 2022
@JuliaSprenger JuliaSprenger added this to the 0.11.0 milestone Jul 1, 2022
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants