Skip to content

Plexon2: Fix conversion between C++ tm structure and python datetime #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apdavison merged 1 commit into from
Jan 26, 2024
Merged

Plexon2: Fix conversion between C++ tm structure and python datetime #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion neo/rawio/plexon2rawio/plexon2rawio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,11 @@ def _parse_header(self):
# invalid datetime information if year is <1
if tmo.tm_year != 0:
microseconds = block_info['m_CreatorDateTimeMilliseconds'] * 1000
dt = datetime(year=tmo.tm_year, month=tmo.tm_mon, day=tmo.tm_mday, hour=tmo.tm_hour,
# tm_mon range is 0..11 https://cplusplus.com/reference/ctime/tm/
# python is 1..12 https://docs.python.org/3/library/datetime.html#datetime.datetime
# so month needs to be tm_mon+1; also tm_sec could cause problems in the case of leap
# seconds, but this is harder to defend against.
dt = datetime(year=tmo.tm_year, month=tmo.tm_mon+1, day=tmo.tm_mday, hour=tmo.tm_hour,
minute=tmo.tm_min, second=tmo.tm_sec, microsecond=microseconds)
# ignoring daylight saving time information for now as timezone is unknown

Expand Down