Add another tests for one file per channel intan rhs #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
h-mayorquin
commented
Apr 2, 2025
| data_from_neo = intan_reader.get_analogsignal_chunk(channel_ids=[channel_name], stream_index=amplifier_stream_index).squeeze() | ||
| np.testing.assert_allclose(data_raw, data_from_neo) | ||
|
|
||
| def test_correct_reading_one_file_per_channel_rhs_stim(self): |
Contributor
There was a problem hiding this comment.
You're right one of the tests got duplicated. Weird I honestly thought it was a diff issue, but it must have been that the tests got reorganized so it didn't connected that they were the same? Not sure. But yeah we should clean that. I doesn't hurt anything, but it's untidy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, @zm711.
I won't have time to fix the file name on gin this week but at least this way you can merge knowing that there is a test for file ordering in the one file per channel case:
#1676