Skip to content

Conversation

@achilleas-k
Copy link
Contributor

Runs the two utility methods before returning loaded Neo Blocks.

See #766.

Runs the two utility methods before returning loaded Neo blocks
@achilleas-k
Copy link
Contributor Author

I believe the circleci tests for NIX are failing because circle isn't pulling down the latest test files but is pulling down the latest nixio beta. The circleci log shows that it's not restoring the test file cache though, so I'm not sure that's the issue, but the error I'm seeing is consistent with what I get when I run the test with nixio-1.5.0b4 and the file before this PR was merged last week in the test file repository.

# parent reference
newchx.block = neo_block

# create object links
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using create_relationship instead of calling these two functions explicitely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of that function (I was going off the IO dev docs). Will update now.

@JuliaSprenger
Copy link
Member

@achilleas-k: In your PR on gin you only updated one of the 3 nix files being present. I tried to run the tests locally and already get the failing tests with one of the non-updated test files. I gues these files might also have an incorrect header?

@achilleas-k
Copy link
Contributor Author

achilleas-k commented Dec 6, 2019

Oh, I see it now. Yes, it was my fault. I wasn't getting the errors locally which is why I assumed it was a caching issue for the CI. Not sure why I wasn't getting the error before, but I get it now as well. Will update the test file on GIN.

EDIT: Pull request open. Thanks for the notice.
https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/14

'create_relationship()' method takes care of both many-to-one and
many-to-many relationship creation.
@JuliaSprenger JuliaSprenger merged commit 9c3cadd into NeuralEnsemble:master Dec 6, 2019
@achilleas-k achilleas-k deleted the fix/nixio-channel-links branch December 6, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants