fix(tauri): restore macOS quit shortcut - #633
Merged
shantur merged 1 commit intoAug 3, 2026
Merged
Conversation
Attach CmdOrCtrl+Q to the existing custom quit menu item so macOS receives the standard Command+Q accelerator. Keep the custom menu event instead of using Tauri's native predefined quit action, ensuring ExitRequested still reaches CodeNomad's coordinated renderer flush and CLI shutdown path. Windows Ctrl+W and Alt+F4 behavior is unchanged. Validated with all 84 Tauri tests, cargo check --locked, rustfmt, diff checks, and repeated Gatekeeper review.
pascalandr
commented
Aug 2, 2026
pascalandr
left a comment
pascalandr
left a comment
Contributor
Author
There was a problem hiding this comment.
Gatekeeper review: zero findings. Verified Cmd+Q accelerator routing through the existing quit menu event and guarded ExitRequested shutdown flow, no frontend shortcut conflict, and unchanged Windows Ctrl+W/Alt+F4 behavior. All 84 Tauri tests, cargo check --locked, rustfmt for main.rs, and diff checks pass.
Contributor
Author
|
@shantur LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The macOS menu used a plain text item with no accelerator. Tauri's predefined native Quit item would restore Cmd+Q, but it bypasses the custom menu event and could skip CodeNomad's coordinated shutdown. A regular menu item with CmdOrCtrl+Q restores the shortcut while preserving cleanup.
Validation
ustfmt check passes for main.rs
Closes #590