fix(ui): stop reasoning output scroll jitter - #653
Open
pascalandr wants to merge 2 commits into
Open
Conversation
Keep bottom-follow anchor correction directional so an already visible sentinel cannot scroll the reasoning output upward between streamed updates. This removes the oscillation caused by bottom padding while preserving downward correction when content grows. Validated with the virtual follow behavior tests, UI typecheck, UI production build, and git diff checks. The reporter's Electron Ubuntu scenario remains the final visual confirmation.
Contributor
Author
|
@shantur LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Streaming first pins the reasoning output to its bottom. The follow-scroll anchor pass then measures the sentinel slightly above the container edge because of bottom padding. The previous absolute-delta check treated that negative offset as actionable and scrolled upward; the next streamed update pinned back to the bottom, producing visible oscillation.
Validation
npm exec --no -- tsx --test packages/ui/src/components/virtual-follow-behavior.test.tsnpm run typecheck --workspace @codenomad/uinpm run build --workspace @codenomad/uigit diff --checkFixes #652