Development#367
Merged
Merged
Conversation
…comments in Avalanche/Base/Cosmos/EOSIO ParkManager second constructor: base class handles all init, comment was vestigial. OAPPManager.PublishToDotNet: remove dead draft comments above working Process.Start call. Avalanche/Base/Cosmos/EOSIO GenerateKeyPair: replace misleading TODO with explanatory comment — provider-specific secp256k1 key generation already done via Nethereum above the KeyHelper call (which is used only as an IKeyPairAndWallet container).
… SetProviderConfig, OASISResultHelper HolonManager.SendHolon<T>: load from sourceProviderType, save to destinationProviderType with error handling. AvatarManager-Private MergeAvatarDetail: add missing Strength/Speed/Dexterity/Toughness/Vitality/Endurance attribute copies. ProviderController.SetProviderConfig: add cases for all providers with ConnectionString (was MongoDB only). OASISResultHelper CopyResult: copy StackTraces alongside InnerMessages in all overloads (was missing).
AptosOASIS: - SaveHolonsAsync: was returning holons unchanged with fake success; now loops SaveHolonAsync for each holon with proper error handling and continueOnError support - DeleteHolonAsync(Guid): was fabricating a Holon from the id without any chain call; now delegates to the string-based overload that calls the Aptos Move delete_holon SC - ImportAsync: was unconditionally returning true without writing anything; now calls SaveHolonsAsync to actually persist holons to Aptos ElrondOASIS: - MintTokenAsync: implements MultiversX ESDTLocalMint via /transaction/send endpoint - BurnTokenAsync: implements MultiversX ESDTNFTBurn via /transaction/send endpoint - LockTokenAsync: sends ESDTNFTTransfer to MultiversX bridge contract with lock argument - UnlockTokenAsync: calls bridge SC unlock function with token identifier OASISBootLoader: - Uncomment NEAROASIS project reference in .csproj (Ed25519 uses System.Security.Cryptography built-ins, no external package required) - Add using NextGenSoftware.OASIS.API.Providers.NEAROASIS - Uncomment NEAROASIS init block so provider can be activated via OASISDNA config
…k (interfaces, models, controller, NFTManager)
…aceWeb4GeoSpatialNFTRequest
…r Edition PDA before we can revoke
SPL Token SetAuthority fails with 0x4 OwnerMismatch on all standard Metaplex NFTs because CreateMasterEditionV3 transfers Mint/Freeze Authority to the Master Edition PDA before our code runs. The PDA has no private key so we can never sign the revoke. Leaving active properties on models while the feature is silently disabled at runtime would be misleading, so RevokeTokenAuthorities is now commented out across all interfaces, request models, controller mappings, and NFTManager sync sites with a comment pointing to SolanaService.cs for the full explanation. FreezeMetadata and all other functionality is unchanged. Build verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.