release(pg_tle): preserve data across 0.3 upgrades - #333
Conversation
NikolayS
left a comment
There was a problem hiding this comment.
REV rubric review
This is a manual execution of the repository's five applicable REV rubrics because the automated ultrareview quota was unavailable. It is not bot output. SOC2 was omitted.
- Bug/security: known updates preserve state and unknown paths refuse destructive guidance; no additional high-confidence defect or security issue found.
- Tests: real pg_tle update/fresh/repeat/unsupported paths are covered; CI is 17/17 green. Initial RED is retrospective.
- Docs/guidelines: final transform shell hardening resolves the touched-file IFS gap. Historical
release:is unsupported by both rule sets and exactly 50 characters;test:/style:also conflict with the repo-specific list.
Blocking patch findings: none. Remaining constraints: preserve history, use a compliant squash/merge subject/title, and post real pg_tle evidence before merge. This COMMENT review is not an approval.
|
Real-user pg_tle verification evidence for head The upgrade test used pg_tle v1.5.2 with a real tagged v0.2.0 extension registration. The documented local sequence was exercised: PAGER=cat psql --no-psqlrc "$PGQUE_TEST_DSN" \
--command='create extension pg_tle'
git show v0.2.0:sql/pgque-tle.sql \
| PAGER=cat psql --no-psqlrc "$PGQUE_TEST_DSN" --set=ON_ERROR_STOP=1
PAGER=cat psql --no-psqlrc "$PGQUE_TEST_DSN" \
--command='create extension pgque'
PAGER=cat psql --no-psqlrc "$PGQUE_TEST_DSN" --set=ON_ERROR_STOP=1 \
--file=tests/test_tle_upgrade.sql
The head passed: I also exercised an unsupported 0.1.0 path. It failed without suggesting destructive uninstall and preserved the installed state: Fresh pg_tle install, idempotent wrapper rerun, extension drop/unregister, and the full regression suite through the pg_tle install path passed. RED/GREEN chronology: retrospective. The main pg_tle upgrade regression was added after the implementation rather than as a published RED commit. I independently confirmed the pre-fix rejection and the head's GREEN behavior. Full CI: 17/17 checks passed. This comment records test evidence only; it is not a review or merge decision. |
Summary
ALTER EXTENSIONpreserves all state and activates the newsend_idemAPIFixes #308.
Validation
tests/run_all.sqlpassed through a fresh pg_tle installbash -n build/transform.shandgit diff --checkpassedactionlintreports only the workflow's pre-existing shellcheck warnings; the added CI step introduces no new warning.