ci: enable wal_consistency_checking in Linux Meson (64-bit) task#75
Draft
NikolayS wants to merge 1 commit into
Draft
ci: enable wal_consistency_checking in Linux Meson (64-bit) task#75NikolayS wants to merge 1 commit into
NikolayS wants to merge 1 commit into
Conversation
WAL consistency checking (027_stream_regress running the full regression suite through a streaming standby with wal_consistency_checking = all) is resource intensive, so the test only turns it on when PG_TEST_EXTRA contains "wal_consistency_checking". No CI task set that, so this valuable check -- verifying that WAL redo reconstructs byte-identical pages on a standby -- had effectively zero coverage in CI. Extend the workflow-level PG_TEST_EXTRA on the Linux - Meson (64-bit) task so 027_stream_regress exercises WAL redo consistency. It's scoped to the "Test world" step of a single Linux task to keep the added cost contained. Locally the run went from ~63s to ~89s wall-clock (11 subtests passing), a modest cost for a heavily used replication task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtxA6B4d47ietk5dGsseuP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable
wal_consistency_checkingcoverage in CI by extendingPG_TEST_EXTRAfor the Linux - Meson (64-bit) task, sosrc/test/recovery/t/027_stream_regress.plturns onwal_consistency_checking = allon the primary.Why
027_stream_regressruns the full regression suite through a streaming standby. It only enables WAL consistency checking whenPG_TEST_EXTRAmatches\bwal_consistency_checking\b(it's resource intensive, hence opt-in):No CI task set that value, so this check — which verifies WAL redo reconstructs byte-identical pages on a standby — had effectively zero coverage in CI. This is exactly the kind of bug (redo routine not matching the original page modification) that is otherwise very hard to catch.
Change
The change is scoped to the "Test world" step of a single Linux task, extending the workflow-level
PG_TEST_EXTRAso the added cost stays contained:Local validation
Built with
meson setup build --buildtype=debug -Dcassert=true -Dtap_tests=enabledand ran027_stream_regressas an unprivileged user:PG_TEST_EXTRAwal_consistency_checkingDelta: roughly +26s (~+41%) for the single task — a modest cost for a heavily used replication code path. testwrap only falls back to the configure-time
--pg-test-extrawhenPG_TEST_EXTRAis absent from the environment, so the workflow-level value flows through correctly.Closes #69
🤖 Generated with Claude Code
https://claude.ai/code/session_01PtxA6B4d47ietk5dGsseuP
Generated by Claude Code