Fix some characterization tests #14341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes had cropped up with `_NIX_TEST_ACCEPT=1`: 1. Blake hashing test JSON had a different indentation 2. Store URI had improper non-quoted spaces (1) was is just fixed, as we trust nlohmann JSON to parse JSON correctly, regardless of whitespace. For (2), the existing URL was made a read-only test, since we very much wish to continue parsing such invalid URLs directly. And then the original read/write test was updated to properly percent-encode the space, as the normal form should be.
xokdvium
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A few changes had cropped up with
_NIX_TEST_ACCEPT=1:Blake hashing test JSON had a different indentation
Store URI had improper non-quoted spaces
(1) was is just fixed, as we trust nlohmann JSON to parse JSON correctly, regardless of whitespace.
For (2), the existing URL was made a read-only test, since we very much wish to continue parsing such invalid URLs directly. And then the original read/write test was updated to properly percent-encode the space, as the normal form should be.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.