libexpr: Do not overflow heap buffer when there are too many formal a… #14439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments 3a3c062 introduced a buffer overflow for the case when there are more than 65535 formal arguments. It is a perfectly reasonable limitation, but we *must* not crash, corrupt memory or otherwise crash the process. Add a test for the graceful behavior and switch to using an explicit uninitialized_copy_n to further guard against buffer overflows.
Ericson2314
approved these changes
Nov 1, 2025
Member
|
Good catch, sorry I missed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rguments
Motivation
3a3c062 introduced a buffer overflow for the case when there are more than 65535 formal arguments. It is a perfectly reasonable limitation, but we must not crash, corrupt memory or otherwise crash the process.
Add a test for the graceful behavior and switch to using an explicit uninitialized_copy_n to further guard against buffer overflows.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.