Remove setting from Input #14550
Merged
Remove setting from Input #14550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
This is more straightforward and not subject to undocumented memory safety restrictions. Also easier to test.
roberth
force-pushed
the
fetchers-settings-arg
branch
from
3f6a527 to
292bd39
Compare
github-actions
bot
added
the
repl
edolstra
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I saw that this is not a large change as part of some experimental work, so I figured y'all could land this cleanup separately.
Surprisingly easy.
This is more straightforward and not subject to undocumented memory safety restrictions.
Also easier to test.
This would have saved me an hour or more on the rust bindings...
EDIT: now complete. It accurately represents that
isLocked()depends on settings 🎉Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.