Remove static data from headers #14551
Merged
+37
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to duplicate any of these across libraries, which is what happens when the platform doesn't support unique symbols.
corngood
commented
Nov 12, 2025
| * to avoid printing "too much" output. | ||
| */ | ||
| static PrintOptions errorPrintOptions = PrintOptions{ | ||
| static constexpr PrintOptions errorPrintOptions = PrintOptions{ |
Contributor
Author
There was a problem hiding this comment.
I just stumbled upon this. It seems to be immutable, but this should cause a compile error if that changes.
Alternatively it could be moved to the library.
corngood
commented
Nov 13, 2025
xokdvium
added
backport 2.29-maintenance
edolstra
removed
backport 2.29-maintenance
edolstra
approved these changes
Nov 13, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to duplicate any of these across libraries, which is what happens when the platform doesn't support unique symbols.
Motivation
Nix on cygwin is broken because the RegisterCommand list is duplicated between nix and libcmd. All subcommands appear to be missing. This works on glibc because the linker uses unique symbols per-process. LTO (which is disabled on cygwin) also has some impact.
Context
See discussion on #13139
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.